-
Notifications
You must be signed in to change notification settings - Fork 262
Allowlist LaunchlyBNBHooks on BNB Chain #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: new-hooks-routing
Are you sure you want to change the base?
Allowlist LaunchlyBNBHooks on BNB Chain #1251
Conversation
|
Hi Uniswap Team, We’ve resolved all conflicts, and our branch is now fully up-to-date with the base branch. Kindly review our hook code repository (as mentioned in the Hook Whitelisting submission form) and our PR when you get a chance. We also realized that our repository was set to private when we initially submitted the form - it has now been made public so the Uniswap team can access the repo and hook contract code without any issues. This hook whitelisting is very important for our upcoming platform launch. Our platform is an ICM Launchpad, enabling project creators from various domains to launch their ideas - leading to significant trading volume across chains. While we have currently submitted the hook for BNB, our platform also supports Base and Ethereum, using the same hook contract logic. We’d like to ensure we meet Uniswap’s requirements before expanding to other chains. Thank you very much for your time and support - we truly appreciate your help with this process. Hook Address - 0x450E0FBfA8f19bC7C35D57FF083adFF7f1B980cC Pool Address (Test token)- 0xe2aa3053e7bacabab466bf2977aac7f31cf59f4c371b575f4e953aa8b21fb12d Thanks, |
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (01/14/26)5 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
jsy1218
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cannot route through this hooked pool:
curl 'https://uodrvgu5rj.execute-api.us-east-2.amazonaws.com/prod/quote?amount=1000000000000000&deadline=1800&enableFeeOnTransferFeeFetching=true&enableUniversalRouter=true&hooksOptions=HOOKS_INCLUSIVE&portionBips=25&portionRecipient=0x5d64D14D2CF4fe5fe4e65B1c7E3D11e18D493091&protocols=v4"eIntent=swap"eSpeed=standard&recipient=0xE49ACc3B16c097ec88Dc9352CE4Cd57aB7e35B95&simulateFromAddress=0xfF3f428583c15a5681584e9e5e86e270418AC4d3&slippageTolerance=2.5&tokenInAddress=BNB&tokenInChainId=56&tokenOutChainId=56&tokenOutAddress=0x90Ced8f4739c44c826e562F91b1D945f38653ca0&type=exactIn&enableDebug=true&requestId=fca167d3-f0b8-4769-a3e0-9db90e3ad159&poolsToManuallyRouteThrough=0xe2aa3053e7bacabab466bf2977aac7f31cf59f4c371b575f4e953aa8b21fb12d' \
-H 'x-universal-router-version: 2.0'
{"detail":"No route found","errorCode":"NO_ROUTE","id":"326fe"}%
is there sufficient liquidity in this pool? from https://app.uniswap.org/explore/pools/bnb/0xe2aa3053e7bacabab466bf2977aac7f31cf59f4c371b575f4e953aa8b21fb12d, doesnt seem like so
|
@jsy1218 Hi Siyu, Thank you for the initial review. Currently, we are working with the Hacken audit agency, and we are addressing a few remediations based on their recommendations. This process is expected to be completed within the next 10 days, after which we will share the final audit report from Hacken with you. At the same time, we will also update PR with changes and provide the new pool address with sufficient liquidity and submit it for your review. We kindly request a little more time to complete these steps. We truly appreciate your support. Please let me know if you have any questions. Have a great day Siyu. |
|
closing the PR was unintended, re-opened, will wait @avco2018 |
|
No worries Siyu. Thanks so much for reopening the PR.
…On Thu, Jan 15, 2026 at 11:04 AM Siyu Jiang (See-You John) < ***@***.***> wrote:
*jsy1218* left a comment (Uniswap/routing-api#1251)
<#1251 (comment)>
closing the PR was unintended, re-opened, will wait @avco2018
<https://github.com/avco2018>
—
Reply to this email directly, view it on GitHub
<#1251 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKPQQXC5JVR5VR4PWZL2WDD4G7CBRAVCNFSM6AAAAACK7NZ3X6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONJVHEZTMMBWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This hook charges a 2% swap fee on every buy and sell involving native assets (e.g., ETH/WBNB) in the pool. It works at the beforeSwap and afterSwap hook stages to detect incoming and outgoing swap amounts. The calculated 2% fee is automatically deducted and sent to a fixed, immutable fee recipient address.
It does not modify pool state beyond fee collection, does not require custom input data, has no admin functions, and is fully non-upgradeable. The contract cannot withdraw or manage pool liquidity, cannot pause trading, and holds no privileged roles. Its only purpose is to take a fixed 2% fee on native asset swaps for revenue-sharing purposes.
https://app.uniswap.org/explore/pools/bnb/0xe2aa3053e7bacabab466bf2977aac7f31cf59f4c371b575f4e953aa8b21fb12d